From: Giovanni Campagna <gcampagna@gnome.org>
Date: Fri, 20 Mar 2015 19:39:01 +0000 (-0700)
Subject: Background: add a comment for questionable GSettings usage
X-Git-Tag: archive/raspbian/50.5-1+rpi1~1^2~1013^2^2~1407
X-Git-Url: https://dgit.raspbian.org/%22http://www.example.com/cgi/%22/%22http:/www.example.com/cgi/%22?a=commitdiff_plain;h=0068098996ed3ca443060800fb3d754421186cdb;p=gnome-shell.git

Background: add a comment for questionable GSettings usage

BackgroundSource relies on Background to watch its own settings.
Add a comment to explain that.

https://bugzilla.gnome.org/show_bug.cgi?id=746509
---

diff --git a/js/ui/background.js b/js/ui/background.js
index 82928e771..5acff9fda 100644
--- a/js/ui/background.js
+++ b/js/ui/background.js
@@ -527,6 +527,10 @@ const BackgroundSource = new Lang.Class({
         let file = null;
         let style;
 
+        // We don't watch changes to settings here,
+        // instead we rely on Background to watch those
+        // and emit 'changed' at the right time
+
         if (this._overrideImage != null) {
             file = Gio.File.new_for_path(this._overrideImage);
             style = GDesktopEnums.BackgroundStyle.ZOOM; // Hardcode